A harsh critic.

Adam Crockett ๐ŸŒ€ - Oct 1 '19 - - Dev Community

Today I did a bad thing, I let go of all restraint during a code review and pointed out all the inconsistencies within a file that my boss wrote... I know, I know what was I thinking!

A review in my eyes, it's not for you, the author, it's for the next person to work on this same code. And sure the code works, but smaller details should not be ignored... Maybe, the truth is I usually bite my tongue under review sinse anything I feel is valuable is just an opinion. My opinion is of fair usage where anything that should be there is there and nothing extra is needed.

Breaking my rule was empowering but unfortunately got me kicked off of the review, that's never happened before and was a complete shock to me. I suppose my job in review isn't to be a human linter.

With a heavy heart I just want to crawl under a rock for the humiliation. But at the same time if my boss had just spoke to me first, I'm sure I would have improved my comments to be more constructive.

. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
Terabox Video Player